Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.x] deps: V8: cherry-pick 217457d0a560 #54883

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[v22.x] deps: V8: cherry-pick 217457d0a560 #54883

merged 1 commit into from
Sep 19, 2024
+190 −7

Conversation

targos
Copy link
Member

@targos targos commented Sep 11, 2024

Fixes a bug in set methods.
This commit is already on main with V8 12.8.

Thanks @ljharb for reporting on Slack.

Original commit message:

[set-methods] Handle SetLike with infinite size

This CL adds a check for identifying SetLikes with infinite sizes in
methods dependent on the size of `other`s.

Bug: 351332634
Change-Id: I5c6d9c0cc7f3f5fae5cedc72a44bc21c917c84b8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5684652
Reviewed-by: Shu-yu Guo <[email protected]>
Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]>
Cr-Commit-Position: refs/heads/main@{#94897}

Refs: v8/v8@217457d

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Sep 11, 2024
@targos targos changed the title deps: V8: cherry-pick 217457d0a560 [v22.x] deps: V8: cherry-pick 217457d0a560 Sep 11, 2024
ljharb
ljharb approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62357/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6189/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6189/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6189/

@targos targos force-pushed the fix-set-methods-v22 branch from 7271c9b to ef84e8d Compare September 16, 2024 06:35
@targos
Copy link
Member Author

targos commented Sep 16, 2024

Rebased

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62474/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6195/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6195/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6195/

@targos
Copy link
Member Author

targos commented Sep 17, 2024

CI passed. Can I have another review to land?

@targos
deps: V8: cherry-pick 217457d0a560
1de5512 
Original commit message:

    [set-methods] Handle SetLike with infinite size

    This CL adds a check for identifying SetLikes with infinite sizes in
    methods dependent on the size of `other`s.

    Bug: 351332634
    Change-Id: I5c6d9c0cc7f3f5fae5cedc72a44bc21c917c84b8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5684652
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Rezvan Mahdavi Hezaveh <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#94897}

Refs: v8/v8@217457d
PR-URL: nodejs#54883
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos force-pushed the fix-set-methods-v22 branch from ef84e8d to 1de5512 Compare September 19, 2024 06:31
@targos targos merged commit 1de5512 into nodejs:v22.x-staging Sep 19, 2024
@targos
Copy link
Member Author

targos commented Sep 19, 2024

Landed in 1de5512

@targos targos deleted the fix-set-methods-v22 branch September 19, 2024 06:32
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @ljharb @richardlau @aduh95 @marco-ippolito